Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure position attribute is always attribute 0 #260

Open
Aeva opened this issue Mar 18, 2017 · 0 comments
Open

ensure position attribute is always attribute 0 #260

Aeva opened this issue Mar 18, 2017 · 0 comments

Comments

@Aeva
Copy link
Owner

Aeva commented Mar 18, 2017

If instanceable uniforms are used, it is possible for the generated attributes to appear before the explicitly defined ones. This can lead to situations where drawing happens when attribute 0 is disabled, which prints a warning that this will result in a horrible slow emulation path on some desktop opengl environments.

It isn't clear if layout qualifiers are available in ES2, and it seems like they probably aren't, so inbefore just adding support for that, the glsl->glsl compiler should be updated to ensure an ideal order.

Aeva pushed a commit that referenced this issue Mar 19, 2017
This commit is an attempt to clean up the horrible technical debt that
has accumulated in the print_program method in the glsl compiler.

And by that, I mean, I rewrote the function from scratch.

This isn't a perfect replacement, and there are currently some
regressions which are evident by running through some of the demos, but
this is a much clearer approach, and I think will make further
development on the compiler much more pleasant.

This relates to issues #260 and #261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant