Feat/reports #32
Open
Feat/reports #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammy-code98
requested changes
Jun 8, 2023
There was a problem hiding this comment.
@Sire6715 great work man.
i did notice that your design of the report modal is quite different from what was given on the design here : https://www.figma.com/file/VxoknphZySezGNvfr63r42/Afrisplash-Final-UI?type=design&node-id=10721-89144&t=hj5SVcQn66rmmw9x-0 .
please compare and make the necessary changes.
|
Yes,still yet to work on the UI |
|
just completed the report modal. |
sammy-code98
approved these changes
Jun 11, 2023
copy-ninja1
requested changes
Jun 11, 2023
| @@ -0,0 +1,72 @@ | |||
| import { | |||
There was a problem hiding this comment.
Rename this component to Search.tsx
| import { AiFillCaretDown } from "react-icons/ai"; | ||
|
|
||
| const Hero = () => { | ||
| return ( |
There was a problem hiding this comment.
this component does not look the same with what is on the ui. please check the ui
sammy-code98
approved these changes
Jun 17, 2023
~ rename Hero.tsx to Search.tsx ~ fix search component to meet ui design ~ add table footer to reports table
sammy-code98
requested review from
copy-ninja1
and removed request for
copy-ninja1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress
having modal issues.