Incomplete fix for NPEs in SmbShareInfo (#108, #136)

AgNO3 · Feb 17, 2019 · ebebc68 · ebebc68
1 parent 1dfe0b5
commit ebebc68
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/jcifs/internal/smb1/net/SmbShareInfo.java b/src/main/java/jcifs/internal/smb1/net/SmbShareInfo.java
@@ -19,6 +19,8 @@
 package jcifs.internal.smb1.net;
 
 
+import java.util.Objects;
+
 import jcifs.SmbConstants;
 import jcifs.smb.FileEntry;
 import jcifs.util.Hexdump;
@@ -126,15 +128,15 @@ public long length () {
     public boolean equals ( Object obj ) {
         if ( obj instanceof SmbShareInfo ) {
             SmbShareInfo si = (SmbShareInfo) obj;
-            return this.netName.equals(si.netName);
+            return Objects.equals(this.netName, si.netName);
         }
         return false;
     }
 
 
     @Override
     public int hashCode () {
-        return this.netName != null ? this.netName.hashCode() : 0;
+        return Objects.hashCode(this.netName);
     }