Slack event api refactor #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow dependabot to check GitHub actions daily * Update .github/dependabot.yml Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com>
* Enable testing using Python 3.9 * Fix linting.
* style: fix lazy logging * style: Remove object inheritance This is no longer needed in python3 versions. * fix: remove unused imports
Fixed rendering issue in docs
fix: merging configs via --storage-merge cli
* Added email property for slack backend * Updated TestPerson with email property * Updated core_plugin whoami command with email * Added missing blank line * fix: whoami format output Co-authored-by: Sijis Aviles <sijis.aviles+github@gmail.com>
This should provide equal behavior as travisci.
This will allow the package to be uploaded to pypi, as it was failing checks.
This should ensure that existing and external backends do not break with when this property is not defined.
* fix: username to userid method signature * Fix username_to_userid and raise when username not uniquely identified (errbotio#1447) * style: fix codestyle warnings Co-authored-by: Carlos <nzlosh@yahoo.com>
The referenced variable name was incorrect.
* docs: Add missing slash in webhook test example * docs: Add webhook example * style: Reformat webhook example
This should handle scenarios where using the --storage-merge cli option does not properly create keys that are not currently stored in storage backend.
* don't try to .strip() when __errdoc__ is None * Update errbot/core_plugins/help.py Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> * Update errbot/core_plugins/help.py Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com>
* docs: Make list out of packaged versions It looks like the plain text is written to be a list, but doesn't follow the reStructuredText format for an unordered list. * docs: Use :code: role for command execution Primarily fix an issue where Docutils Smart Quotes transformation will turn double-dash `--` into en-dash `–`. This might be confusing to new users who copy and paste from the text but don't realize the CLI option should be double-dash.
* refactor: Split changelog by major versions Also ensured that content was actually in rst format. * fix: package description content-type definition * style: Use non-curly quotes * style: fix v4.x headings * style: minor fixes with newlines
* Allow dependabot to check GitHub actions daily * Update .github/dependabot.yml Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com> Co-authored-by: Sijis Aviles <sijis.aviles@gmail.com>
* Enable testing using Python 3.9 * Fix linting.
…fact it supports RTM and Event API.
…rrbot into slack_event_api_support
…ack_event_api_refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.