Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Way for Callers to Access Form Data #16

Merged
merged 1 commit into from Feb 14, 2017
Merged

Conversation

chrisguitarguy
Copy link
Member

Which is useful for things like conditional rendering.

PMG's specific use case is that we need access to the form data to change something in a dialog window based on form data.

Which is useful for things like conditional rendering.

PMG's specific use case is that we need access to the form data to
change something in a dialog window based on form data.
@ericelsken
Copy link
Member

I like this. But I would also like to see this data go to the validator functions or in the validation context.
I guess that would be a separate PR anyway.

Copy link
Member

@ericelsken ericelsken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on the conversation tab.

@chrisguitarguy chrisguitarguy removed the request for review from ChrisAlvares February 14, 2017 14:06
@chrisguitarguy chrisguitarguy merged commit 657851a into master Feb 14, 2017
@chrisguitarguy chrisguitarguy deleted the form_data branch February 14, 2017 14:07
@chrisguitarguy
Copy link
Member Author

But I would also like to see this data go to the validator functions or in the validation context.

Agreed, but yeah, that's another PR. I have some ideas on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants