Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Logs are not fetched in cloud #1685

Merged
merged 6 commits into from
May 24, 2024
Merged

[Enhancement]: Logs are not fetched in cloud #1685

merged 6 commits into from
May 24, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented May 20, 2024

Depends on #369

@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:46am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request Frontend labels May 20, 2024
@bekossy bekossy requested a review from aybruhm May 20, 2024 16:31
aakrem
aakrem requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy thanks for the PR
Let's please add a loader.

Screen.Recording.2024-05-21.at.19.59.14.mov

@bekossy bekossy requested a review from aakrem May 21, 2024 21:25
@aakrem
Copy link
Collaborator

aakrem commented May 22, 2024

@bekossy
Can we please remove the view that contains the "restart container" which disappears very fast ?

Screen.Recording.2024-05-22.at.14.19.24.mov

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 24, 2024
@aakrem aakrem merged commit d00e446 into main May 24, 2024
8 checks passed
@aakrem aakrem deleted the cloud-issue-369/-enhancement-logs-are-not-fetched branch May 24, 2024 06:22
@aakrem
Copy link
Collaborator

aakrem commented May 24, 2024

thanks @bekossy

@aakrem aakrem mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem approved these changes

@aybruhm aybruhm Awaiting requested review from aybruhm

Assignees
No one assigned
Labels
enhancement New feature or request Frontend lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bekossy @aakrem