New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial readme instructions #11
Add initial readme instructions #11
Conversation
When you say WIP do you intend to keep on working? |
@Felistas Thank you for jumping in and working on this ticket. What I would like to see, as part of the workflow instructions, is a variant--if not exactly--of the following:
Keep in mind that if you write instructions for forking the repo, they would have to run In other words, tell them to run something like this command: git remote add upstream https://github.com/AgileVentures/WebsiteOne-FE |
Yes @joaopapereira there are some few things I want to add. I wouldn't mind feedback too. @FedericoEsparza I will definitely implement that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks pretty good
CONTRIBUTION_GUIDE.md
Outdated
|
||
After that run | ||
``` | ||
git merge upstream develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Felistas Would you mind explaining the purpose of this command git merge upstream develop
? I think it might end up confusing newcomers, as it has confused me. Might it not be necessary, since we already ran git pull upstream develop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedericoEsparza I don't think its necessary.You are right.
@Felistas I agree with @joaopapereira . The rest is looking great. I like the initiative to create the Please see my additional comment on that file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good going to merge
* Add initial readme instructions * Add contributing guide instructions * Minor edits to the contribution.md file * hot fix
* Add initial readme instructions * Add contributing guide instructions * Minor edits to the contribution.md file * hot fix
Fixes #3
Screenshot:
Contribution.md Preview