Add create new project #142
Conversation
ghost
assigned 
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://websiteone-fe-git-fork-aonomike-139createnewprojects.agileventures1.now.sh |
aonomike
force-pushed
the
139_create_new_projects
branch
from
04ea9ae
to
0015820
Compare
aonomike
force-pushed
the
139_create_new_projects
branch
from
0015820
to
5cea89e
Compare
aonomike
force-pushed
the
139_create_new_projects
branch
from
326a018
to
9ad144e
Compare
src/components/ProjectForm.js
Outdated
| <option value='Active' >Active</option> | ||
| <option value='Inactive'>Inactive</option> | ||
| </select> | ||
| <Button type='submit' > Submit </Button> </Form > |
There was a problem hiding this comment.
What do you think we if we call this Create Project
| expect(wrapper.find('ProjectForm')).toHaveLength(1) | ||
| }) | ||
|
|
||
| // it('calls handleSubmit when the form is submitted', () => { |
There was a problem hiding this comment.
Why is this test commented out?
| .get('textarea[name=description]') | ||
| .type('A new project') | ||
| .get('select[name=status]') | ||
| .get('button[type=submit]') |
There was a problem hiding this comment.
sorry, I just noticed this @aonomike, why are we selecting the status? we aren't doing anything with it
| cy.fixture('newlyCreatedProjectInfo').then(newlyCreatedProjectInfo => { | ||
| cy.route(/\/api\/v1\/projects\/newproject/, newlyCreatedProjectInfo).as('getProject') | ||
| cy.visit('/projects/newproject') | ||
| cy.window() |
There was a problem hiding this comment.
I think we want to change this cypress test to do what we are doing with the create events functionality in the React Mob.
You rightly brought up the bug that the way I had written the test was actually not testing that a user is being redirected by a successfully created event/project because I was, and you are, visiting the newlyCreatedProject.
| import initialState from './initialState' | ||
|
|
||
| const createProjectReducer = (state = initialState.project, action) => { | ||
| switch (action.type) { |
There was a problem hiding this comment.
As I brought up to you @aonomike, I am having doubts about what the point of saving the newlyCreatedProject/Event to the store when we are redirecting the user to the newlyCreatedProject/Event's info page where it reaches out to the backend to grab the project's/event's info.
maybe it's a refactor? @joaopapereira what do you think? I can't think of any reason we need to have the user carry around the newlyCreatedProject/Event's info since the info they request from the backend on componentDidMount on the ProjectInfo.js/EventInfo.js includes all of the project's/event's info plus other info.
There was a problem hiding this comment.
In the Stephen Grider course, he also does dispatch the response after create to store, maybe its just a convention? maybe there is something to it. Your thoughts @Kachulio1 @arku @FedericoEsparza @joaopapereira ?
| }) | ||
|
|
||
| it('calls method to push the user to the events info page', () => { | ||
| moxios.wait(() => { |
There was a problem hiding this comment.
really like that you had the idea to test for this, especially since we need to pass in a mock functionf for history.push, we might as well test that it's being called 😸
good catch... need to create refactoring tickets to borrow your ideas 😸
| describe('CreateProjectPage', () => { | ||
| let wrapper | ||
| let props = { | ||
| history: { push: jest.fn() }, |
There was a problem hiding this comment.
do we need this, or was this added when we were thinking of handling the redirection from the CreateProjectPage.js?
- Add cypress tests for the create new project - Add components for CreateProjectPage - Add route for 'projects/new'
- Implement handleChange - Start implement handleSubmit
Co-authored-by: abdellani <abdellani@gmail.com>
- The implementation now creates new project - Add dispatch error for CreatePeojectAction
… create project reducer
aonomike
force-pushed
the
139_create_new_projects
branch
from
8c5b81c
to
3f79f8c
Compare
Issue addressed
fixes #139
Screenshots (if appropriate):
Testing