Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows test and document it #176

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix windows test and document it #176

merged 1 commit into from
Apr 5, 2019

Conversation

mtc2013
Copy link
Member

@mtc2013 mtc2013 commented Apr 4, 2019

Fixes #175

@ghost ghost assigned mtc2013 Apr 4, 2019
@ghost ghost added the review label Apr 4, 2019
@vercel
Copy link

vercel bot commented Apr 4, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://websiteone-fe-git-175windowtesting.agileventures1.now.sh

joaopapereira
joaopapereira approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joaopapereira joaopapereira merged commit 88436fb into develop Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the 175_window_testing branch April 5, 2019 19:06
@ghost ghost added production and removed review labels Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

@Kachulio1 Kachulio1 Awaiting requested review from Kachulio1

@mattwr18 mattwr18 Awaiting requested review from mattwr18

Assignees

@mtc2013 mtc2013

Labels
production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtc2013 @joaopapereira