200 -redirect user to login if not logged in and tries to access '/project/new' #208

ALau2088 · 2019-04-25T17:35:33Z

Add Private route to App.js line51.
Add Private route component. If there is no session or user data redirect to login else continue to project/new. This is based on same logic as the CreateEventPage.js container.

Issue addressed

fixes #200

Screenshots (if appropriate):

Testing

vercel · 2019-04-25T17:35:38Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://websiteone-fe-git-fork-alau2088-200-userredirect.agileventures1.now.sh

mattwr18 · 2019-04-25T18:33:15Z

hey thanks for putting this in @ALau2088! 😸
Can you run yarn fix before pushing up the code? it will fail our build if there are semi-colons, double quotes, etc.

mattwr18 · 2019-04-25T18:35:11Z

src/components/App.js

-                cookies={this.props.cookies}
-              />)
-          }}
+          <PrivateRoute exact path='/projects/new' component={NewProject} />


why do we need a PrivateRoute here?
we can do something similar to the CreateEventPage where we save a user's lastLocation in our redux store, check if a user is logged in, and if not redirect them to the login page.

mattwr18 · 2019-04-25T18:35:52Z

src/components/NewProject.js

+
+export default function NewProject() {
+  return (
+    <Fragment>


we already have a way to create new projects, please check out CreateProjectPage

maybe the issue was not clear enough? let me make update to explicitly state this

Got it. Just seeing the CreateProjectPage now. I will update my fork and make the requested changes shortly.

great @ALau2088, thanks for making the requested changes! 😸
just a slight change to the tests is needed see 👇

mattwr18 · 2019-04-29T18:55:28Z

@ALau2088 currently failing the build with this output

 Error: Uncaught [TypeError: Cannot read property 'pathname' of undefined]

can you try updating it similar to this?
https://github.com/AgileVentures/WebsiteOne-FE/blob/develop/src/tests/containers/CreateEventPage.test.js#L9

vercel · 2019-04-29T22:44:22Z

Deployment failed with the following error:

You defined 1 build that did not match any source files (please ensure they are NOT defined in .nowignore):

ALau2088 · 2019-04-29T23:09:21Z

@mattwr18 . I made the requested edit and it passed the CircleCI test.

ALau2088 · 2019-05-03T05:33:46Z

@mattwr18 @aonomike . Hey guys, it just occurred to me that these changes were made to the CreateProjectPage prior to converting to redux-form. I could go ahead and implement this in the redux-form version of the components but before I do just wanted to check with you guys if this is the correct approach. Thanks in advance.

chris110408 · 2019-05-03T06:55:11Z

@mattwr18 @aonomike @ALau2088

there is another option I just find is formsy-semantic-ui-react . https://github.com/zabute/formsy-semantic-ui-react
this one is easy to use and do not mutate the store by itself.
It is really easy to use and should able to handle all jobs required for this project

mattwr18 · 2019-05-04T18:46:36Z

hey @ALau2088, sorry I am just replying to this now, I have been real busy the last couple days.
I think for now we are going forward with Redux-Form, although we want to treat @chris110408 concerns as valid and explore the option of changing the direction and refactoring.

We need to talk about it in the next meeting, which will be Tuesday... up to you if you want to wait till then or not, but I think if you do want to go ahead and refactor, we can always open up a ticket later that you or someone else can work on.

At the moment, there are merge conflicts, so if you could rebase before you make any changes, it will make your life a bit easier.

aonomike · 2019-05-06T11:11:02Z

Thanks @ALau2088 I ran this locally and looks great. Maybe we can have a session to add cypress tests?

ALau2088 · 2019-05-06T19:08:02Z

@aonomike Sure. Want to have session tomorrow Tuesday 5/7 10am-12pm Pacific Standard Time?
I am also available Thursday 5/9 8am-11am or during the React Mob MeetUp at 7am.

joaopapereira · 2019-05-14T17:26:03Z

Fixes #200

mattwr18 · 2019-05-21T15:27:36Z

Any progress on this @ALau2088??

ALau2088 · 2019-05-21T18:20:51Z

Hey @mattwr18 . Thanks for the reminder. I added a setLastLocation test and redirect test and am ready to push it up to the PR but my branch files (CreateProjectPage.js and CreateProjectPage.test.js are behind the upstream files. My initial thought was to merge the upstream and branch but I wanted to see if you had any thoughts on going about this? Also I was curious what is the use of the setLastLocation action?

mattwr18 · 2019-05-21T19:01:03Z

you can run git rebase upstream/develop from your feature branch @ALau2088, then work through the merge conflicts

ALau2088 · 2019-05-22T05:06:51Z

Thanks @mattwr18 . The changes have been pushed up to the PR.

ALau2088 requested review from aonomike, nataliyah123 and mattwr18 April 25, 2019 17:35

ghost assigned ALau2088 Apr 25, 2019

ghost added the review label Apr 25, 2019

vercel bot deployed to staging April 25, 2019 17:35 View deployment

ALau2088 mentioned this pull request Apr 25, 2019

Redirect user to Login page if not logged and attempts to create new project #200

Open

mattwr18 requested changes Apr 25, 2019

View reviewed changes

redirect user to login if not logged in

a480331

ALau2088 force-pushed the 200-userRedirect branch from da54869 to a480331 Compare April 25, 2019 20:43

vercel bot deployed to staging April 25, 2019 20:43 View deployment

redirect user to login if not logged in

670ad8b

vercel bot deployed to staging April 25, 2019 20:51 View deployment

update props for CreateProjectPage.test.jst

8ccc97f

vercel bot deployed to staging April 29, 2019 22:34 View deployment

update props in CreateProjectPage.test.js

b937f56

vercel bot requested a deployment to staging April 29, 2019 22:44 Abandoned

package.json

3266eac

vercel bot deployed to staging April 29, 2019 22:52 View deployment

vercel bot deployed to staging May 6, 2019 21:04 View deployment

vercel bot deployed to staging May 9, 2019 17:15 View deployment

joaopapereira requested a review from mattwr18 May 14, 2019 16:54

add setLastLocation and reDirect tests

cfb95d9

ALau2088 added 3 commits May 21, 2019 21:27

rebase files

b797fd4

200-userRedirect

754b58c

200-userRedirect

f297de6

ALau2088 force-pushed the 200-userRedirect branch from 893e318 to f297de6 Compare May 22, 2019 04:56

vercel bot deployed to staging May 22, 2019 04:56 View deployment

200-userRedirect

033f566

vercel bot deployed to staging May 22, 2019 05:00 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

200 -redirect user to login if not logged in and tries to access '/project/new' #208

200 -redirect user to login if not logged in and tries to access '/project/new' #208

ALau2088 commented Apr 25, 2019 •

edited by aonomike

vercel bot commented Apr 25, 2019 •

edited

mattwr18 commented Apr 25, 2019

mattwr18 Apr 25, 2019

mattwr18 Apr 25, 2019

aonomike Apr 25, 2019

ALau2088 Apr 25, 2019

mattwr18 Apr 29, 2019

mattwr18 commented Apr 29, 2019

vercel bot commented Apr 29, 2019

ALau2088 commented Apr 29, 2019

ALau2088 commented May 3, 2019

chris110408 commented May 3, 2019 •

edited

mattwr18 commented May 4, 2019

aonomike commented May 6, 2019

ALau2088 commented May 6, 2019

joaopapereira commented May 14, 2019

mattwr18 commented May 21, 2019

ALau2088 commented May 21, 2019

mattwr18 commented May 21, 2019

ALau2088 commented May 22, 2019

200 -redirect user to login if not logged in and tries to access '/project/new' #208

Are you sure you want to change the base?

200 -redirect user to login if not logged in and tries to access '/project/new' #208

Conversation

ALau2088 commented Apr 25, 2019 • edited by aonomike

Issue addressed

Screenshots (if appropriate):

Testing

vercel bot commented Apr 25, 2019 • edited

mattwr18 commented Apr 25, 2019

mattwr18 Apr 25, 2019

Choose a reason for hiding this comment

mattwr18 Apr 25, 2019

Choose a reason for hiding this comment

aonomike Apr 25, 2019

Choose a reason for hiding this comment

ALau2088 Apr 25, 2019

Choose a reason for hiding this comment

mattwr18 Apr 29, 2019

Choose a reason for hiding this comment

mattwr18 commented Apr 29, 2019

vercel bot commented Apr 29, 2019

ALau2088 commented Apr 29, 2019

ALau2088 commented May 3, 2019

chris110408 commented May 3, 2019 • edited

mattwr18 commented May 4, 2019

aonomike commented May 6, 2019

ALau2088 commented May 6, 2019

joaopapereira commented May 14, 2019

mattwr18 commented May 21, 2019

ALau2088 commented May 21, 2019

mattwr18 commented May 21, 2019

ALau2088 commented May 22, 2019

ALau2088 commented Apr 25, 2019 •

edited by aonomike

vercel bot commented Apr 25, 2019 •

edited

chris110408 commented May 3, 2019 •

edited