Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added redux-form to ProjectForm #211

Merged

Conversation

jmpainter
Copy link
Contributor

@jmpainter jmpainter commented Apr 28, 2019

package.json - added redux-form, react-semantic-redux-form. For testing added redux-mock-store
src/components/ProjectForm.js - converted to redux-form using react-semantic-redux-form
src/containers/CreateProjectPage.js - removed state and function related to form
src/store/index.js - added form reducer from redux-form
src/tests/components/ProjectForm.test.js - modified for redux-form
src/tests/containers/CreateProjectPage.test.js - modified for redux-form
src/tests/store/store.test.js - modified to include form reducer from redux-form

fixes #187

@vercel
Copy link

vercel bot commented Apr 28, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://websiteone-fe-git-fork-jmpainter-187-create-project-redux-form.agileventures1.now.sh

@jmpainter
Copy link
Contributor Author

One of the cypress tests is failing in the circleci build- create_events.feature. This is passing locally - I'm not sure what the issue is. Could anyone help with this? Thanks!

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joaopapereira joaopapereira merged commit cc390a3 into AgileVentures:develop Apr 30, 2019
@ghost ghost added production and removed review labels Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Create New Project to use redux-form
2 participants