Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 add image url field to projects form #217

Merged

Conversation

47analogy
Copy link
Contributor

Issue addressed

fixes #201
Added an input field to new projects form for user to be able to provide image url

Screenshots (if appropriate):

Testing

@ghost ghost assigned 47analogy Apr 29, 2019
@ghost ghost added the review label Apr 29, 2019
@vercel
Copy link

vercel bot commented Apr 29, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://websiteone-fe-git-fork-47analogy-201-add-image-url-field.agileventures1.now.sh

@47analogy 47analogy changed the title 201 add image url field WIP - 201 add image url field May 5, 2019
@47analogy 47analogy changed the title WIP - 201 add image url field 201 add image url field May 5, 2019
@47analogy 47analogy changed the title 201 add image url field [WIP] 201 add image url field May 5, 2019
@47analogy 47analogy changed the title [WIP] 201 add image url field 201 add image url field to projects form May 5, 2019
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Please run standard in the code and push again

@mattwr18
Copy link
Contributor

mattwr18 commented May 7, 2019

hey @47analogy, as @joaopapereira stated, if you run yarn fix locally, it won't fail the build cause of linting issues.

Also, a good trick is if you run yarn test locally it will run standard first, then you will get notified before it fails the build for linting issues.

@joaopapereira joaopapereira merged commit 46339c7 into AgileVentures:develop May 8, 2019
@ghost ghost added production and removed review labels May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image url input field in the projects form
3 participants