Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

169 shrink video icons #250

Merged

Conversation

clementkng
Copy link
Contributor

Shrank the font-size on the video icons so they are more proportional to videos.

Issue addressed

fixes #169

Screenshots (if appropriate):

image

Testing

@vercel
Copy link

vercel bot commented May 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://websiteone-fe-git-fork-clementkng-169-shrink-video-icons.agileventures1.now.sh

@mattwr18
Copy link
Contributor

what do you think @joaopapereira... maybe there could be side effects?

@joaopapereira
Copy link
Member

Not sure if there is a side effect because it is associated with a specific class. I am ok with merging it as long as it solves the current problem

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 338014d into AgileVentures:develop May 30, 2019
@clementkng clementkng deleted the 169-shrink-video-icons branch May 30, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video play icons too large
3 participants