Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProjectsList container, tests #41

Merged
merged 2 commits into from Jan 22, 2019
Merged

Conversation

mattwr18
Copy link
Contributor

@mattwr18 mattwr18 commented Jan 15, 2019

Issue addressed

fixes #34

Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the pr did not match the story.
I am a bit confused. Please review my comments

<StaticRouter context={context}>
<ProjectsList
projects={projectsFixture}
fetchProjects={() =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did look like last the story.

</StaticRouter>
)

it('should have a header Volunteers Directory', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect text

@mattwr18 mattwr18 changed the title Add UsersList container, tests Add ProjectsList container, tests Jan 17, 2019
@ghost ghost assigned joaopapereira Jan 22, 2019
@ghost ghost added the review label Jan 22, 2019
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge

@joaopapereira joaopapereira merged commit 8d4565c into develop Jan 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the 34-projects-container branch January 22, 2019 14:03
@ghost ghost removed the review label Jan 22, 2019
mattwr18 added a commit that referenced this pull request Jan 29, 2019
bryszard pushed a commit that referenced this pull request Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Projects Container
2 participants