Update specific gems #2420
Merged
Update specific gems #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have configured this |
nisevi
force-pushed
the
2419_update_specific_gems
branch
from
342ba9f
to
11d9285
Compare
This was referenced Jun 9, 2018
|
Hi there guys @FedericoEsparza @tansaku @NickSchimek if you can take a look to this PR I will really appreciate it 🚀 |
NickSchimek
suggested changes
Jun 10, 2018
There was a problem hiding this comment.
@nisevi With the removal of the rack timeout configs specifically the one for development we will no longer be able to use byebug effectively since the request will take to long.
Please update the docs to add the following environment variable to the .env file.
RACK_TIMEOUT_SERVICE_TIMEOUT=200000000
This will make it so that we don't timeout on our local development environments when debugging.
Remove unnecessary initializer. Add env variable to documentation. 'paper_trail' upgraded.
nisevi
force-pushed
the
2419_update_specific_gems
branch
from
11d9285
to
69e9c42
Compare
|
@NickSchimek |
NickSchimek
approved these changes
Jun 11, 2018
mattwr18
pushed a commit
that referenced
this pull request
Jan 28, 2019
Remove unnecessary initializer. Add env variable to documentation. 'paper_trail' upgraded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue: #2419