add test for first query #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr1d99
reviewed
Nov 17, 2020
| names = result.collect {|x| x["name"]} | ||
|
|
||
| assert names.detect { |e| e == 'FirstEvent' } | ||
| assert names.detect { |e| e == 'AnotherEvent' } |
There was a problem hiding this comment.
Is assert provided by RSpec? It looks like a minitest assertion.
It would be nice to use RSpec expectations here.
There was a problem hiding this comment.
We tried using expect(array_one).to match(array_two) and assert array_one =~ array_two plus a couple more but they were just not working, so Matt made a this work around, I guess we will be looking into it more. Maybe they don't work easy with GQL? not sure...
There was a problem hiding this comment.
I put those lines in a custom rspec matcher, which may be the best I can do. Does that look better?
mattlindsey
commented
Nov 20, 2020
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| class GraphqlController < ApplicationController | |||
| before_action :fetch_params, only: [:execute] | |||
| skip_before_action :verify_authenticity_token | |||
There was a problem hiding this comment.
The following should be added when we start doing adds, updates, and deletes:
except: [:create, :update, :destroy]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91