Refactor tests to pull out the mountMockedProvider functions #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a separate file to contain the mountMockedProvider function which is re-used in a number of tests, making it generic Co-authored-by: Riccardo Giomi <contact@riccardogiomi.com>
riccardo-giomi
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
Refactoring to pull out a reused function
How should this be manually tested?
yarn testWhat are the relevant Github Issues ?
Fixes #482
Screenshots (If applicable)
Co-authored-by: Riccardo Giomi contact@riccardogiomi.com