Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to staging #133

Merged
merged 17 commits into from Dec 14, 2019
Merged

Merge develop to staging #133

merged 17 commits into from Dec 14, 2019

Conversation

aonomike
Copy link
Collaborator

What does this PR do?

Merge dev to stag

Description of Task to be completed?

How should this be manually tested?

  1. On terminal, run command ...

Any background context you want to provide?

What are the relevant Github Issues ?

Screenshots (If applicable)

aonomike and others added 17 commits November 13, 2019 23:02
- Implements that the scope and limit variables are used to manipulate the result of the causes query

Co-Authored-By: Azure May <azure.may.burmeister@gmail.com>
- Add ability for trending causes to be limited in the causes query

Co-Authored-By: Azure May <azure.may.burmeister@gmail.com>
- In test_helpers.exs
- Remove redundant setup code for causes
…ariable-in-same-causes-query

Implement limit and scope variable in same causes query
- Create gql schema and resolver for signup

## Todo
[X] Implement query user in the schema
[X] Create session schema
- User is now able to signup
- Added functionality to hash the password
- Create user factory
- Add me query to return current user details
- Add current user to the context of the application
UserTypes
})

alias SingForNeedsWeb.Resolvers.{Accounts, Artist, Cause, Performance}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time you are using the multiple single line alias/require/import/use directives but here you are using the multi-alias/require/import/use syntax

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).
  • 1 fixed issue! 🎉

But beware that this branch is 4 commits behind the AgileVentures:staging branch, and a review of an up to date branch would produce more accurate results.

See more details about this review.

@javpet javpet merged commit 055ba60 into staging Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants