-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from lattice.dispatch to ct.dispatch #55
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
===========================================
+ Coverage 71.79% 71.90% +0.10%
===========================================
Files 23 27 +4
Lines 1468 1502 +34
===========================================
+ Hits 1054 1080 +26
- Misses 414 422 +8
Continue to review full report at Codecov.
|
Only thing left to update is the website. |
Will need to run the how tos, tutorials again to check if they are still working. Tests seem to be passing which take how-tos into account. |
The only place its not updated is the website. |
@kessler-frost can you slack me once this is merged and in pip ? I will update it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @kessler-frost ! 🔥
dispatcher=ct.dispatch(run_experiment)
id=dispatcher(*params)
Only suggestion -
Using nested functions is an advanced pattern and not a beginner to intermediate friendly pattern. Could you change user facing example (atleast in read me) to a pattern as above where it is a bit more easier to digest than nested calls like func()()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a couple of (non-blocking) questions that require some clarification. Also, for the sake of good practise, is it possible to add some unit tests for base and local.py? I know this is a huge issue already.
@kessler-frost Looks great! Just had a couple of questions and I think it would be good practise to write some unit tests for base and local.py. |
@FyzHsn I agree, I'll add some tests for |
I really don't want to be the tests guy. But somehow, I can never escape it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-blocking) I'd create an issue to add more in-depth unit tests for the wrappers in the local dispatcher. Also, you might want to put in Deprecation warning like @santoshkumarradha mentioned to give users a chance to adapt and not have all their code break suddenly. However, covalent has only been OS for a week, so it might be fine.
Syntax needs to be updated in concepts.rst
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to be merged (depending on @santoshkumarradha 's thoughts on the deprecation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THE BEST ! 🔥 🚀 🤼♀️
Resolves #48