Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Refactor getters to functions #12

Closed
Ascenio opened this issue Jul 1, 2021 · 1 comment · Fixed by #16
Closed

[PROPOSAL] Refactor getters to functions #12

Ascenio opened this issue Jul 1, 2021 · 1 comment · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@Ascenio
Copy link
Contributor

Ascenio commented Jul 1, 2021

There are these two cases in AgoraClient that getters are used to get async information.

https://github.com/AgoraIO-Community/Flutter-UIKit/blob/4ab388978f322caf99234420f5e8f510ebcd0a34/lib/src/agora_client.dart#L15-L30

This is often thought as not good practice because it tricks the client into thinking that it's a cached or O(1) operation. This is not recommended by Flutter guideline.

So maybe it should be changed to a function to make its computation more explicit.

@Ascenio Ascenio added the enhancement New feature or request label Jul 1, 2021
@Ascenio Ascenio mentioned this issue Jul 1, 2021
23 tasks
@tadaspetra
Copy link
Contributor

Changes merged in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants