Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes getters #16

Merged

Conversation

Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Jul 1, 2021

Closes #12.

Removes async and Future when not needed.
Turns platformSession into getPlatformVersion().

Release Notes

  • AgoraClient's users is not async anymore.
  • Turns platformSession into getPlatformVersion().

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The client has to await for AgoraClient.users even thought it's synchronous.

Issue Number: #12

What is the new behavior?

The client doesn't have to await for AgoraClient.users anymore.

Does this introduce a breaking change?

  • Yes
  • No

QA Checklist

UIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

UIKit Update Checklist (Major Release)

  • The above checklist is completed (except backwards compatibility)
  • Thoroughly tested for crashes, across multiple platforms at the same time

QA Notes

I swapped out the platformVersion for getPlatformVersion(), but I have no strong feelings, it could be platformVersion(). Let me know what you guys think.

@Ascenio Ascenio changed the title Fix/turn getters into functions Fixes getters Jul 2, 2021
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tadaspetra tadaspetra changed the base branch from main to dev July 2, 2021 18:55
@Meherdeep Meherdeep merged commit 7aa6b42 into AgoraIO-Community:dev Jul 6, 2021
@Ascenio Ascenio deleted the fix/turn-getters-into-functions branch July 6, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Refactor getters to functions
3 participants