Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.
Removes async and Future when not needed.
Turns
platformSession
intogetPlatformVersion()
.Release Notes
users
is not async anymore.platformSession
intogetPlatformVersion()
.Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The client has to await for
AgoraClient.users
even thought it's synchronous.Issue Number: #12
What is the new behavior?
The client doesn't have to await for
AgoraClient.users
anymore.Does this introduce a breaking change?
QA Checklist
UIKit Update Checklist (Minor or Patch Release)
UIKit Update Checklist (Major Release)
QA Notes
I swapped out the
platformVersion
forgetPlatformVersion()
, but I have no strong feelings, it could beplatformVersion()
. Let me know what you guys think.