Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI bug #122

Closed
ag84ark opened this issue Jan 23, 2023 · 2 comments
Closed

Small UI bug #122

ag84ark opened this issue Jan 23, 2023 · 2 comments

Comments

@ag84ark
Copy link

ag84ark commented Jan 23, 2023 •
edited
Loading

I think this should be:

widget.enableHostControl == null || widget.enableHostControl  == false

Now, if you put false, it still shows them, actually you can't make them disappear.

VideoUIKit-Flutter/lib/src/layout/floating_layout.dart

Line 257 in 726f3ad

widget.enableHostControl ==

VideoUIKit-Flutter/lib/src/layout/floating_layout.dart

Line 373 in 726f3ad

widget.enableHostControl ==

VideoUIKit-Flutter/lib/src/layout/floating_layout.dart

Line 450 in 726f3ad

child: widget.enableHostControl == null || false

@maxxfrazer
Copy link
Contributor

maxxfrazer commented Jan 25, 2023 •
edited
Loading

@Meherdeep looks like @ag84ark is right here.

or the condition could be changed to widget.enableHostControl != true.

Also, thanks for the issue @ag84ark!

@Meherdeep Meherdeep mentioned this issue Feb 14, 2023
Merged
@Meherdeep
Copy link
Contributor

Fixed with v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxxfrazer @ag84ark @Meherdeep