Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v1.2.0 #123

Merged
merged 6 commits into from
Mar 2, 2023
Merged

release v1.2.0 #123

merged 6 commits into from
Mar 2, 2023

Conversation

Meherdeep
Copy link
Contributor

  • Added screen sharing for Android/iOS
  • Added layout for one to one video calling
  • Fixes issue #122

@tadaspetra
Copy link
Contributor

Several Issues I ran into:

  • If clicking screenshare, then cancel before starting it, button shows active screenshare.
  • While screen sharing, local user turns off camera feed, the screenshare will stop
  • iOS screenshare not coming through on other device
  • audio coming through even though mic is disabled

@Meherdeep
Copy link
Contributor Author

@maxxfrazer @tadaspetra I made some changes to the PR that solves all the issues reported in the above comment. Please take a look at it.

@maxxfrazer
Copy link
Contributor

nice one! will take a look and run from my end.

tadaspetra
tadaspetra approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

maxxfrazer
maxxfrazer approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Meherdeep Meherdeep merged commit f9a14b5 into main Mar 2, 2023
@Meherdeep Meherdeep deleted the screen-sharing branch March 2, 2023 11:42
@muj-i muj-i mentioned this pull request Mar 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxfrazer maxxfrazer maxxfrazer approved these changes

@tadaspetra tadaspetra tadaspetra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meherdeep @tadaspetra @maxxfrazer