Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Custom Widgets #103

Closed
wants to merge 7 commits into from
Closed

Added Custom Widgets #103

wants to merge 7 commits into from

Conversation

jabguru
Copy link

@jabguru jabguru commented Sep 29, 2022

Release Version: 1.0.5

Release Notes

  • Added Custom Empty View Widget
  • Added Custom Number of Users Widget
  • Enabled buttons rendered in order

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The built-in buttons are not displayed in the order that they are put in enabledButtons.

Issue Number: N/A

What is the new behavior?

  • Added emptyViewWidget. Was having an issue with the expanded widget on the default one and I needed to use localization on the text (waiting for the host to join), so I figured a custom widget would be needed.
  • Added numberOfUsersWidget. Needed to customize the widget that displays the number of users connected, so I added a function that takes in the number from the controller and returns the widget.

Does this introduce a breaking change?

  • Yes
  • No

QA Checklist

VideoUIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

QA Notes

Other information

I'm kinda new to this markdown thing, so if there's something I need to add or didn't add and I need to fix so the pull request can be accepted, please reach out. I'm grateful for the work being put into this packaged, helped me a great deal! Thanks.

@jabguru jabguru closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant