Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubspec.yaml #117

Closed
wants to merge 1 commit into from
Closed

Update pubspec.yaml #117

wants to merge 1 commit into from

Conversation

amalnathm7
Copy link

Release Version:

Release Notes

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 114

What is the new behavior?

  • Forcefully uses older version of pubspec.yaml
  • Produces no errors

Does this introduce a breaking change?

  • Yes
  • No

QA Checklist

VideoUIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

VideoUIKit Update Checklist (Major Release)

  • The above checklist is completed (except backwards compatibility)
  • Thoroughly tested for crashes, across multiple platforms at the same time

QA Notes

Other information

@maxxfrazer
Copy link
Contributor

Hi @amalnathm7, thanks for the PR!

We tried a dry run of publishing the package with a similar change locally and found that setting the dependency to a specific version like that does result in the following publishing error from pub.dev:
Your dependency on "agora_rtc_engine" should allow more than one version

Instead we've updated the package to handle the breaking change from RTC Engine 6.1.0, and set it to work for >= 6.1.0 <6.2.0, with the assumption that no breaking changes are added to the next patch (MAJOR.MINOR.PATCH). Please update to Agora UI Kit v1.1.1 to get these changes.

Thanks again, and we'll try to make sure these upgrades do not disrupt users of the package in the future!

@maxxfrazer maxxfrazer closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants