Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cloud recording being shown by default #129

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

tadaspetra
Copy link
Contributor

Release Version: 1.3.1

Release Notes

  • BUG FIX: No longer shows cloud recording by default. Need to enable it with cloudRecordingEnabled: true

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

QA Checklist

VideoUIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

VideoUIKit Update Checklist (Major Release)

  • The above checklist is completed (except backwards compatibility)
  • Thoroughly tested for crashes, across multiple platforms at the same time

QA Notes

Other information

Copy link
Contributor

@Meherdeep Meherdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tadaspetra tadaspetra merged commit 279a812 into main Mar 16, 2023
@tadaspetra tadaspetra deleted the cloud-recording branch March 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants