Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video source type breaking change #136

Merged
merged 2 commits into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.3

- BREAKING CHANGE: VideoSourceType for `onFirstLocalVideoFrame` callback

## 1.3.2

- Added callback for cloud recording destination URL
Expand Down
4 changes: 2 additions & 2 deletions lib/controllers/rtc_event_handlers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ Future<RtcEngineEventHandler> rtcEngineEventHandler(
}, onFirstLocalAudioFramePublished: (connection, elapsed) {
agoraEventHandlers.onFirstLocalAudioFramePublished
?.call(connection, elapsed);
}, onFirstLocalVideoFrame: (connection, width, height, elapsed) {
}, onFirstLocalVideoFrame: (videoSourceType, width, height, elapsed) {
agoraEventHandlers.onFirstLocalVideoFrame
?.call(connection, width, height, elapsed);
?.call(videoSourceType, width, height, elapsed);
}, onFirstLocalVideoFramePublished: (connection, elapsed) {
agoraEventHandlers.onFirstLocalVideoFramePublished
?.call(connection, elapsed);
Expand Down
2 changes: 1 addition & 1 deletion lib/models/agora_rtc_event_handlers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class AgoraRtcEventHandlers {
/// * [height] The height (px) of the first local video frame.
/// * [elapsed] Time elapsed (ms) from the local user calling joinChannel [2/2] until the SDK triggers this callback. If you call startPreview before calling joinChannel [2/2], then this parameter is the time elapsed from calling the startPreview method until the SDK triggers this callback.
final void Function(
RtcConnection connection, int width, int height, int elapsed)?
VideoSourceType videoSourceType, int width, int height, int elapsed)?
onFirstLocalVideoFrame;

/// Occurs when the first video frame is published.
Expand Down
2 changes: 1 addition & 1 deletion lib/models/agora_rtm_mute_request.dart
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class AgoraUIKit {
String platform = platformStr();

String framework = "flutter";
String version = "1.3.2";
String version = "1.3.3";

AgoraUIKit.fromJson(Map<String, dynamic> json)
: platform = json['platform'],
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: agora_uikit
description: Flutter plugin to simply integrate Agora Video Calling or Live
Video Streaming to your app with just a few lines of code.
version: 1.3.2
version: 1.3.3
homepage: https://www.agora.io/en/
repository: https://github.com/AgoraIO-Community/VideoUIKit-Flutter

Expand Down
Loading