Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mainAgoraUser logic #138

Merged
merged 5 commits into from
Jun 13, 2023
Merged

update mainAgoraUser logic #138

merged 5 commits into from
Jun 13, 2023

Conversation

Meherdeep
Copy link
Contributor

@maxxfrazer maxxfrazer linked an issue May 24, 2023 that may be closed by this pull request
when layoutType is floating, i got this error #137
Closed
maxxfrazer
maxxfrazer approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. that was quite a big breaking change from SDK 6.1.1, is it in the notes for that release?

tadaspetra
tadaspetra approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tadaspetra tadaspetra mentioned this pull request Jun 13, 2023
Closed
@Meherdeep Meherdeep merged commit 5eca240 into main Jun 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxfrazer maxxfrazer maxxfrazer approved these changes

@tadaspetra tadaspetra tadaspetra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when layoutType is floating, i got this error
3 participants
@Meherdeep @maxxfrazer @tadaspetra