Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Active Speaker when overrided #158

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Disable Active Speaker when overrided #158

merged 3 commits into from
Sep 28, 2023

Conversation

tadaspetra
Copy link
Contributor

@tadaspetra tadaspetra commented Sep 27, 2023 •
edited by maxxfrazer

Release Version: 1.3.7

Release Notes

  • Fixes active speaker bug when user overrides with manual pin

Please check the type of change your PR introduces:

  • Bugfix

What is the current behavior?

When a user is pinned, activeSpeaker tries to override that pin causing an exception

Issue Number: N/A

What is the new behavior?

When user manually pins someone, activeUser detection is disabled until that user is unpinned

Does this introduce a breaking change?

  • No

maxxfrazer
maxxfrazer approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@maxxfrazer maxxfrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Any chance we could update permission_handler to 11.0.0? if it's not a simple change feel free to merge and update later.

Meherdeep
Meherdeep approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Meherdeep Meherdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tadaspetra tadaspetra merged commit 7da5a92 into main Sep 28, 2023
2 checks passed
@tadaspetra tadaspetra deleted the active-speaker-fix branch September 28, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxfrazer maxxfrazer maxxfrazer approved these changes

@Meherdeep Meherdeep Meherdeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadaspetra @maxxfrazer @Meherdeep