-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning the rtm code, upgrading to the latest version, rtm event han… #78
Conversation
Meherdeep
commented
Apr 27, 2022
- Updated RTC v5.1.0
- Cleaning the session controller
- RTM client and channel event handlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Meherdeep for your hard work getting this PR ready!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Suggestion for the future: I like how the functions are separated into the appropriate files, but the controllers
folder maybe isn't a good name for it. The two controllers are rtm_controller.dart
and session_controller.dart
the other ones are helper files. They still work for the controllers so it doesn't really matter but could be nice to add some more folders to keep things organized.
@tadaspetra I completely agree with your point. The only reason why it is still named |