Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTM 1.1.1 Compatibility #87

Merged
merged 5 commits into from
May 30, 2022
Merged

Fix RTM 1.1.1 Compatibility #87

merged 5 commits into from
May 30, 2022

Conversation

maxxfrazer
Copy link
Contributor

@maxxfrazer maxxfrazer commented May 30, 2022

Release Version: 1.1.1

Release Notes

  • Add Error param to delegate methods to pass through the error
  • Show correct versions of RTC and RTM
  • Show RTM classes

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix

What is the current behavior?

Issue Number: N/A

Does this introduce a breaking change?

  • No

QA Checklist

UIKit Update Checklist (Minor or Patch Release)

  • Using the latest version of Agora's Video SDK
  • Example apps are all functional
  • Core features are still working (both ways across platforms)
    • Camera + Mic muting works for local and remote users
    • Users are added and removed correctly when they join and leave the channel
    • Older versions of the library gracefully handle changes (Create issue if not)
    • Builtin buttons all work as expected
  • Any newly deprecated methods are flagged as such inline and in documentation

Copy link
Contributor

@Meherdeep Meherdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxxfrazer maxxfrazer merged commit f50124f into main May 30, 2022
@maxxfrazer maxxfrazer deleted the rtm-update-fix branch May 30, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants