Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Suggestions #1

Closed
onyii5119 opened this issue Feb 2, 2022 · 4 comments
Closed

Some Suggestions #1

onyii5119 opened this issue Feb 2, 2022 · 4 comments

Comments

@onyii5119
Copy link

Thanks for coming up with the idea of a higher level API for demystifying Agora video processing. The Agora Web UI Kit is easy to use. I applaud you for that. Nonetheless, for a developer with need to integrate video into a business systems, some heavy customization might be needed. Look and feel is what UI is all about. It is great, one can recompose the UI and I think that's where most serious developers will put their focus on if they want to use the kit.

I am assuming you wrote the kit for easy integration to UI frameworks and in particular React developers. I know it is COOL to use TypeScript for development. But I can tell you that as a consultant that work with US companies "Raw React JS" is used 95% of the time because it is easier to integrate with other components used heavily in most companies.

My humble suggestions (others can help in the implementation)

  1. A good example of the kit using just pure React (no TypeScript). There is simple TypeScript example already.
  2. A detailed example of recomposing the kit using raw React and TypeScript with emphasis on:
  • capturing local and remote video
  • How to customize the video containers, buttons and icons with the freedom to place icons and control bars in any desired location
  • In short a better exposure (example) on how to use most of the functions and props in raw React and TypeScript.
  1. I am open to help build a POC application by recomposing the UI Kit.

Thanks Agora for your SDKs and special thanks to Ekaansh Arora for coming up with UI web kit.

Jonathan Ekwempu

@EkaanshArora
Copy link
Contributor

Hi @onyii5119, thank you so much for your feedback!

We're working on the blog draft to cover in detail how to recompose the UIKit, you can check out the project repo

I think TypeScript adds a lot to the developer experience but using it is completely optional with the Web UIKit, I'm adding a non-typescript example to this branch based on your feedback.

  1. no-typescript branch
  2. You can check out the mentioned example: typescript and non-typescript. We'll add it to the docs/wiki for better visibility.

We'll continue to work on adding detailed guides for the different parts that you mentioned.

Excited to hear what you think, thanks!

@onyii5119
Copy link
Author

onyii5119 commented Feb 7, 2022 via email

@onyii5119
Copy link
Author

onyii5119 commented Feb 7, 2022 via email

@EkaanshArora
Copy link
Contributor

EkaanshArora commented Feb 8, 2022

Try clearing ./node_modules and reinstalling the dependencies.
Or better yet create a fresh react project with your preferred configuration (npx create-react-app demo) and then you just copy-paste the App.tsx file from ./example, make sure you install the UIKit (npm i agora-react-uikit).

digitallysavvy added a commit that referenced this issue May 7, 2024
digitallysavvy added a commit that referenced this issue May 7, 2024
Merge pull request #1 from digitallysavvy/v2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants