3.6.0-rc.2-build.111 (#638)

AgoraIO-Extensions · Jan 11, 2022 · 3b2a429 · 3b2a429
1 parent 98b3c8f
commit 3b2a429
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 3.6.0-rtc.2-build.111(Jan 11th, 2021)
+- fix dll import for windows
+
 ## 3.6.0-rtc.2-build.110(Jan 10th, 2021)
 - update native sdk
 

diff --git a/agora_node_ext/agora_rtc_engine.cpp b/agora_node_ext/agora_rtc_engine.cpp
@@ -7204,6 +7204,10 @@ NAPI_API_DEFINE(NodeRtcEngine, getDefaultAudioPlaybackDevices) {
     char deviceName[MAX_DEVICE_ID_LENGTH] = {0};
     char deviceId[MAX_DEVICE_ID_LENGTH] = {0};
     Local<v8::Object> dev = v8::Object::New(args.GetIsolate());
+    if (!pdc) {
+      args.GetReturnValue().Set(dev);
+      return;
+    }
     pdc->getDefaultDevice(deviceName, deviceId);
     auto dn = v8::String::NewFromUtf8(args.GetIsolate(), deviceName,
                                       NewStringType::kInternalized)
@@ -7238,6 +7242,10 @@ NAPI_API_DEFINE(NodeRtcEngine, getDefaultAudioRecordingDevices) {
     char deviceName[MAX_DEVICE_ID_LENGTH] = {0};
     char deviceId[MAX_DEVICE_ID_LENGTH] = {0};
     Local<v8::Object> dev = v8::Object::New(args.GetIsolate());
+    if (!pdc) {
+      args.GetReturnValue().Set(dev);
+      return;
+    }
     pdc->getDefaultDevice(deviceName, deviceId);
     auto dn = v8::String::NewFromUtf8(args.GetIsolate(), deviceName,
                                       NewStringType::kInternalized)

diff --git a/binding.gyp b/binding.gyp
@@ -290,9 +290,9 @@
                         './sdk/dll/libagora-wgc.dll',
                         './sdk/dll/libagora_fdkaac.dll',
                         './sdk/dll/libagora_ci_extension.dll',
-                        './sdk/dll/libagora_fd_extension',
-                        './sdk/dll/libagora_mpg123',
-                        './sdk/dll/libagora_video_process_extension',
+                        './sdk/dll/libagora_fd_extension.dll',
+                        './sdk/dll/libagora_mpg123.dll',
+                        './sdk/dll/libagora_video_process_extension.dll',
                         './sdk/dll/libagora-ffmpeg.dll',
                         './sdk/dll/libagora-soundtouch.dll',
                         './sdk/dll/libhwcodec.dll',

diff --git a/configs/binding32.gyp b/configs/binding32.gyp
@@ -277,9 +277,9 @@
                         './sdk/dll/libagora-wgc.dll',
                         './sdk/dll/libagora_fdkaac.dll',
                         './sdk/dll/libagora_ci_extension.dll',
-                        './sdk/dll/libagora_fd_extension',
-                        './sdk/dll/libagora_mpg123',
-                        './sdk/dll/libagora_video_process_extension',
+                        './sdk/dll/libagora_fd_extension.dll',
+                        './sdk/dll/libagora_mpg123.dll',
+                        './sdk/dll/libagora_video_process_extension.dll',
                         './sdk/dll/libagora-ffmpeg.dll',
                         './sdk/dll/libagora-soundtouch.dll',
                         './sdk/dll/libhwcodec.dll',

diff --git a/configs/binding64.gyp b/configs/binding64.gyp
@@ -278,9 +278,9 @@
                         './sdk/dll/libagora-wgc.dll',
                         './sdk/dll/libagora_fdkaac.dll',
                         './sdk/dll/libagora_ci_extension.dll',
-                        './sdk/dll/libagora_fd_extension',
-                        './sdk/dll/libagora_mpg123',
-                        './sdk/dll/libagora_video_process_extension',
+                        './sdk/dll/libagora_fd_extension.dll',
+                        './sdk/dll/libagora_mpg123.dll',
+                        './sdk/dll/libagora_video_process_extension.dll',
                         './sdk/dll/libagora-ffmpeg.dll',
                         './sdk/dll/libagora-soundtouch.dll',
                         './sdk/dll/libhwcodec.dll',

diff --git a/just-task.js b/just-task.js
@@ -116,7 +116,7 @@ task('build:node', () => {
 // npm run download --
 task('download', () => {
   // work-around
-  const addonVersion = '3.6.0-rc.2-build.110'
+  const addonVersion = '3.6.0-rc.2-build.111'
   cleanup(path.join(__dirname, "./build")).then(_ => {
     cleanup(path.join(__dirname, './js')).then(_ => {
       download({
@@ -137,7 +137,7 @@ task('install', () => {
   }
 
   // work-around
-  const addonVersion = '3.6.0-rc.2-build.110'
+  const addonVersion = '3.6.0-rc.2-build.111'
   if (config.prebuilt) {
     download({
       electronVersion: config.electronVersion, 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "agora-electron-sdk",
-  "version": "3.6.0-rc.2-build.110",
+  "version": "3.6.0-rc.2-build.111",
   "description": "agora-electron-sdk",
   "main": "js/AgoraSdk.js",
   "types": "types/AgoraSdk.d.ts",