Skip to content

Commit

Permalink
feat: allow unregister event handler by specific eventHandler
Browse files Browse the repository at this point in the history
  • Loading branch information
guoxianzhe committed Mar 14, 2024
1 parent a8256c0 commit 87843c0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions ts/Private/internal/RtcEngineExInternal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,16 @@ export class RtcEngineExInternal extends IRtcEngineExImpl {
}

override registerEventHandler(eventHandler: IRtcEngineEventHandler): boolean {
// only call iris when no event handler registered
let callIris = RtcEngineExInternal._event_handlers.length === 0;
if (
!RtcEngineExInternal._event_handlers.find(
(value) => value === eventHandler
)
) {
RtcEngineExInternal._event_handlers.push(eventHandler);
}
return super.registerEventHandler(eventHandler);
return callIris ? super.registerEventHandler(eventHandler) : true;
}

override unregisterEventHandler(
Expand All @@ -250,7 +252,9 @@ export class RtcEngineExInternal extends IRtcEngineExImpl {
RtcEngineExInternal._event_handlers.filter(
(value) => value !== eventHandler
);
return super.unregisterEventHandler(eventHandler);
// only call iris when no event handler registered
let callIris = RtcEngineExInternal._event_handlers.length === 0;
return callIris ? super.unregisterEventHandler(eventHandler) : true;
}

override createMediaPlayer(): IMediaPlayer {
Expand Down

0 comments on commit 87843c0

Please sign in to comment.