Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate CoreEval submission in passed proposals against actual passed proposal #67

Open
turadg opened this issue Jan 15, 2024 · 1 comment · May be fixed by #84
Open

validate CoreEval submission in passed proposals against actual passed proposal #67

turadg opened this issue Jan 15, 2024 · 1 comment · May be fixed by #84
Assignees
@turadg

Comments

@turadg
Copy link
Member

turadg commented Jan 15, 2024

Some proposals pull their CoreEval submissions from the web. Some use a subdir on disk.

The subdir is good because it doesn't make CI dependent on network requests to wherever the CoreEval is stored.

But we need some way to validate that they match. It could be manual and also in CI as advisory.
@turadg turadg mentioned this issue Jan 15, 2024
Merged
@mhofman
Copy link
Member

mhofman commented Jan 15, 2024

Note, to pull from a mainnet RPC node itself, the following should work:

agd query gov proposal $PROPOSAL_NUM -o json | jq -r '.content.evals'

Yields the following shape:

[
  {
    "json_permits": "..."
    "js_code": "..."
  }
]

This was referenced Jan 23, 2024
Merged
Draft
@turadg turadg self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

save proposal from archive node Agoric/agoric-3-proposals
2 participants
@turadg @mhofman