Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crabble-start passed in 64 #65

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: crabble-start passed in 64 #65

merged 1 commit into from
Jan 15, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 15, 2024

closes: #62

@turadg turadg requested review from mhofman and dckc January 15, 2024 18:15
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could pull artifacts that were published on chain from an authoritative source, but I don't see the final artifacts in a release on the source repo

I pulled the core eval info from the proposal itself, and note only minor differences:

diff --git a/proposals/c:crabble-start/assets/crabble-permit.json b/proposals/c:crabble-start/assets/crabble-permit.json
index 8eb0b89..b35b482 100644
--- a/proposals/c:crabble-start/assets/crabble-permit.json
+++ b/proposals/c:crabble-start/assets/crabble-permit.json
@@ -21,4 +21,4 @@
       "CrabbleGovernor": true
     }
   }
-}
\ No newline at end of file
+}
diff --git a/proposals/c:crabble-start/assets/crabbleCoreEval.js b/proposals/c:crabble-start/assets/crabbleCoreEval.js
index 8f8d88e..d9eb6ac 100644
--- a/proposals/c:crabble-start/assets/crabbleCoreEval.js
+++ b/proposals/c:crabble-start/assets/crabbleCoreEval.js
@@ -248,3 +248,4 @@ const start = async (powers, config) => {
 harden(start);
 
 start;
+
diff --git a/proposals/c:crabble-start/assets/gov-permit.json b/proposals/c:crabble-start/assets/gov-permit.json
index b7ed1c9..26639fb 100644
--- a/proposals/c:crabble-start/assets/gov-permit.json
+++ b/proposals/c:crabble-start/assets/gov-permit.json
@@ -8,4 +8,4 @@
   "produce": {
     "startCrabbleGovernedUpgradable": true
   }
-}
\ No newline at end of file
+}
diff --git a/proposals/c:crabble-start/assets/govStarting.js b/proposals/c:crabble-start/assets/govStarting.js
index 29514f1..ef8fc0a 100644
--- a/proposals/c:crabble-start/assets/govStarting.js
+++ b/proposals/c:crabble-start/assets/govStarting.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-shadow */
 /**
  * @file Add support for starting governed contracts to the Agoric bootstrap /
  *   CoreEval "promise space".
@@ -15,14 +16,14 @@ const ParamTypes = /** @type {const} */ ({
 const { fromEntries, entries } = Object;
 
 /** @type { <T extends Record<string, ERef<any>>>(obj: T) => Promise<{ [K in keyof T]: Awaited<T[K]>}> } */
-const allValues = async obj => {
+const allValues = async (obj) => {
   const es = await Promise.all(
     entries(obj).map(async ([k, v]) => [k, await v]),
   );
   return fromEntries(es);
 };
 
-const logger = message => {
+const logger = (message) => {
   console.log('[PRODUCE_UPGRADABLE_STARTER]', message);
 };
 
@@ -75,7 +76,7 @@ const startCrabbleGovernedInstance = async (
     committeeCreatorFacet,
   },
 ) => {
-  const logger = message => {
+  const logger = (message) => {
     console.log('[START_GOVERNED_INSTANCE]', message);
   };
 
@@ -215,3 +216,4 @@ harden(produceStartCrabbleGovernedUpgradable);
 
 // script completion value
 produceStartCrabbleGovernedUpgradable;
+

I also note that #62 mentions something about a TODO, but that seems unrelated to representing the actual state of the chain.

@turadg
Copy link
Member Author

turadg commented Jan 15, 2024

I wish we could pull artifacts that were published on chain from an authoritative source

Agree. @dckc had earlier proposals pulling from the web. Here's what I propose,

Thanks for checking for differences and posting them here.

@turadg turadg merged commit a0b00be into main Jan 15, 2024
3 checks passed
@turadg turadg deleted the 62-crable-64 branch January 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crabble went to mainnet in proposal 64
2 participants