fix(cosmos): avoid low gas estimates when simulated admission fails

Agoric · Apr 30, 2023 · a2a0f9d · a2a0f9d
1 parent 2b2bc96
commit a2a0f9d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/golang/cosmos/ante/vm_admission.go b/golang/cosmos/ante/vm_admission.go
@@ -35,8 +35,10 @@ func (ad AdmissionDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate boo
 	for _, msg := range tx.GetMsgs() {
 		if camsg, ok := msg.(vm.ControllerAdmissionMsg); ok {
 			if err := camsg.CheckAdmissibility(ctx, ad.data); err != nil {
-				errors = append(errors, err)
+				// Only let admission errors interrupt the transaction if we're not
+				// simulating, otherwise our gas estimation will be too low.
 				if !simulate {
+					errors = append(errors, err)
 					defer func(msg sdk.Msg) {
 						telemetry.IncrCounterWithLabels(
 							[]string{"tx", "ante", "admission_refused"},