Skip to content

Commit

Permalink
lint: use ban-ts-comment
Browse files Browse the repository at this point in the history
prefer-ts-expect-error was deprecated
typescript-eslint/typescript-eslint#9081
  • Loading branch information
turadg committed Jun 9, 2024
1 parent 4d2c509 commit e7b0ceb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,14 @@ module.exports = {
reportUnusedDisableDirectives: true,

rules: {
'@typescript-eslint/prefer-ts-expect-error': 'error',
'@typescript-eslint/ban-ts-comment': [
'error',
{
// TODO tigthen to 'allow-with-description'
'ts-expect-error': false,
'ts-nocheck': false,
},
],
'@typescript-eslint/no-floating-promises': 'error',
// so that floating-promises can be explicitly permitted with void operator
'no-void': ['error', { allowAsStatement: true }],
Expand Down
2 changes: 1 addition & 1 deletion packages/zone/src/durable.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const makeDurableZone = (baggage, baseLabel = 'durableZone') => {
/** @type {import('.').Zone['exoClass']} */
const exoClass = (...args) => prepareExoClass(baggage, ...args);
/** @type {import('.').Zone['exoClassKit']} */
// eslint-disable-next-line @typescript-eslint/prefer-ts-expect-error -- happens only integrating with Endo master
// eslint-disable-next-line @typescript-eslint/ban-ts-comment -- happens only integrating with Endo master
// @ts-ignore FIXME in Endo
const exoClassKit = (...args) => prepareExoClassKit(baggage, ...args);
/** @type {import('.').Zone['exo']} */
Expand Down

0 comments on commit e7b0ceb

Please sign in to comment.