feat: cli for sending Wallet{Spend}Action transactions #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
added
enhancement
michaelfig
approved these changes
Apr 20, 2022
| @@ -18,6 +18,10 @@ import ( | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| ) | |||
|
|
|||
| const ( | |||
| FlagSpend = "spend" | |||
There was a problem hiding this comment.
Suggested change
| FlagSpend = "spend" | |
| FlagAllowSpend = "allow-spend" |
| }, | ||
| } | ||
|
|
||
| cmd.Flags().Bool(FlagSpend, false, "Send a WalletSpendAction transaction if true") |
There was a problem hiding this comment.
Suggested change
| cmd.Flags().Bool(FlagSpend, false, "Send a WalletSpendAction transaction if true") | |
| cmd.Flags().Bool(FlagAllowSpend, false, "Allow the WalletAction to spend assets if specified") |
My wording's not so great. Alternatives in this direction would be appreciated.
There was a problem hiding this comment.
Done. Wording seems fine except trimmed the redundant "if true" at the end.
JimLarson
force-pushed
the
5141-wallet-cli
branch
from
f7aec13
to
c78f7c7
Compare
JimLarson
added
the
automerge:no-update
dckc
added a commit
that referenced
this pull request
Jul 18, 2022
dckc
added a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5141
Description
Commands for sending
WalletActionandWalletSpendActiontransactions.Security Considerations
Ensures address and JSON are valid but performs no other checks.
Documentation Considerations
Needs long description?
Testing Considerations
Needs some end-to-end testing, currently difficult to automate.