Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade ses to 0.12.3 to avoid console noise #2552

Merged
merged 4 commits into from
Mar 2, 2021
Merged

fix: upgrade ses to 0.12.3 to avoid console noise #2552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c70bc8e
fix: upgrade ses to 0.12.3 to avoid console noise
dckc Mar 2, 2021
270ca56
fix(notifier): update harden() type from make-hardener 0.1.3
dckc Mar 2, 2021
df1c2ee
chore(dapp-svelte-wallet): upgrade ses
michaelfig Mar 2, 2021
84f9ccf
fix: workaround vega error by preloading it
michaelfig Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/assert/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@
"access": "public"
},
"dependencies": {
"ses": "^0.12.2"
"ses": "^0.12.3"
}
}
2 changes: 1 addition & 1 deletion packages/bundle-source/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"acorn": "^7.1.0",
"esm": "^3.2.5",
"rollup": "^1.32.0",
"ses": "^0.12.2",
"ses": "^0.12.3",
"source-map": "^0.7.3"
},
"keywords": [],
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp-svelte-wallet/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"rollup-plugin-livereload": "^1.0.0",
"rollup-plugin-svelte": "^5.0.3",
"rollup-plugin-terser": "^6.1.0",
"ses": "^0.12.2",
"ses": "^0.12.3",
"sirv-cli": "^1.0.0",
"smelte": "^1.0.15",
"svelte": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/install-ses/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"@agoric/eventual-send": "^0.13.2",
"ses": "^0.12.2"
"ses": "^0.12.3"
},
"files": [
"src/**/*.js"
Expand Down
15 changes: 14 additions & 1 deletion packages/swingset-runner/bin/runner
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,20 @@
* Simple boilerplate program providing linkage to launch an application written using modules within the
* as yet not-entirely-ESM-supporting version of NodeJS.
*/
import lmdb from 'node-lmdb';

// LMDB bindings need to be imported before lockdown.
import 'node-lmdb';

// FIXME: Without importing vega ahead of lockdown,
// node -r esm bin/runner --init --memdb run demo/encouragementBot
// exits with error code 1, just printing `{}`.
//
// Since this started with ses@0.12.3 we suspect vega is somehow
// hitting the override mistake with `constructor`.
import 'vega';
Comment on lines +13 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the comment is too specific. The problem will occur with any invocation of swingset-runner regardless of the command line options.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2575


// Now do lockdown.
import '../src/install-optional-metering-and-ses';
import { main } from '../src/main.js';

main();
2 changes: 1 addition & 1 deletion packages/xsnap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@agoric/eventual-send": "^0.13.2",
"@agoric/install-ses": "^0.5.1",
"esm": "^3.2.5",
"ses": "^0.12.2"
"ses": "^0.12.3"
},
"devDependencies": {
"@rollup/plugin-node-resolve": "^6.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/zoe/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"ava": "^3.12.1",
"esm": "^3.2.25",
"nyc": "^15.1.0",
"ses": "^0.12.2"
"ses": "^0.12.3"
},
"files": [
"bundles/",
Expand Down
21 changes: 8 additions & 13 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,10 @@
dependencies:
ses "^0.11.0"

"@agoric/make-hardener@^0.1.0":
version "0.1.1"
resolved "https://registry.yarnpkg.com/@agoric/make-hardener/-/make-hardener-0.1.1.tgz#9b887da47aeec6637d9db4f0a92a4e740b8262bb"
integrity sha512-3emNc+yWJoFK5JMLoEFPs6rCzkntWQKxpR4gt3jaZYLKoUG4LrTmID3XNe8y40B6SJ3k/wLPodKa0ToQGlhrwQ==

"@agoric/make-hardener@^0.1.2":
version "0.1.2"
resolved "https://registry.yarnpkg.com/@agoric/make-hardener/-/make-hardener-0.1.2.tgz#b9a72d98ae23a4c6918cd7dc4a9a72deebafde45"
integrity sha512-l5O7TCVDcl6NcWW5Rp/lAQaFLmje97wHrKPJbYV08M4TNDgSiMlesYtar40OnAR2pnzgsyilSQc+hU5mEvCJWg==
"@agoric/make-hardener@^0.1.0", "@agoric/make-hardener@^0.1.2":
version "0.1.3"
resolved "https://registry.yarnpkg.com/@agoric/make-hardener/-/make-hardener-0.1.3.tgz#807b0072bef95d935c3370d406d9dfeb719f69ee"
integrity sha512-rc9M2ErE/Zu822OLCnAltr957ZVTsBvVZ7KA2unqDpjo3q7PqZF2hWFB1xXD2Qkfwt5exQ3BjFbkj+NUaTg4gA==

"@agoric/nat@^4.0.0":
version "4.0.0"
Expand Down Expand Up @@ -9245,10 +9240,10 @@ ses@^0.11.0:
"@agoric/make-hardener" "^0.1.0"
"@agoric/transform-module" "^0.4.1"

ses@^0.12.2:
version "0.12.2"
resolved "https://registry.yarnpkg.com/ses/-/ses-0.12.2.tgz#ac8180eb8ec8e12652f352c2f3fae0b19be03465"
integrity sha512-XhzToLDYbT4liHNzt+GY6RNP64e+pi2ioCgyYztXt6ZnsSF4UttaN1EXEzDZoPjU67Nym7f8bSQiVRu7tezD5g==
ses@^0.12.3:
version "0.12.3"
resolved "https://registry.yarnpkg.com/ses/-/ses-0.12.3.tgz#9092a1f54374d08571a62837954e3fa24fe31d0f"
integrity sha512-uDAUbVECNcgbl90ZwKCsmp5II/rgS1hiiB6KQMBU+GDvsUA+NFXdH76o3bTIk3ftPHqc4Vyk7vAU75pd+3Jy2Q==
dependencies:
"@agoric/babel-standalone" "^7.9.5"
"@agoric/make-hardener" "^0.1.2"
Expand Down