Renovate timer services #3853
Renovate timer services #3853
Conversation
There was a problem hiding this comment.
I don't understand the changes to notifier. Let's zoom sometime.
Be aware of https://github.com/Agoric/agoric-sdk/blob/master/packages/notifier/README.md
I haven't looked at it in a while. If we do go ahead with this change, please check if that doc needs to be updated.
michaelfig
force-pushed
the
mfig-timer-renovation
branch
from
4e62c2b
to
fb2c4a3
Compare
In the interest of decoupling this optimisation from the more urgent changes needed to solve the issues at hand, I've moved the notifier changes and the reliance on them to a new PR #3854. |
michaelfig
force-pushed
the
mfig-timer-renovation
branch
from
fb2c4a3
to
f505504
Compare
michaelfig
force-pushed
the
mfig-timer-renovation
branch
from
f505504
to
7a2c830
Compare
Excellent, thanks! |
|
With that gone, would you mind if I unlisted myself as a reviewer of this PR? |
Go right ahead! (I couldn't figure out how to do that, but I tried.) |
packages/SwingSet/docs/timer.md
Outdated
| Then users in the REPL can use the `localTimerService` or `chainTimerService` | ||
| (both in seconds) to schedule wakeups. |
There was a problem hiding this comment.
This seems inconsistent with the above. Is localTimerService in seconds or milliseconds?
There was a problem hiding this comment.
Used to be seconds (but was incorrect). Now I've moved to milliseconds and corrected the polling to be accurate.
| createRepeater(delay, interval) { | ||
| delay = Nat(delay); | ||
| interval = Nat(interval); | ||
| return timerService.makeRepeater(delay, interval); |
There was a problem hiding this comment.
I think this is a good opportunity to get rid of the deprecated createRepeater(). It's only used in one test in agoric-sdk. I doubt it's used outside this repo.
michaelfig
force-pushed
the
mfig-timer-renovation
branch
from
dda819b
to
3654717
Compare
In this PR:
TimerService.delay(RelativeTime)to resolve a Promise after a delayTimerService.createRepeaterswingset-runnermanualTimer.jschainTimerServicecorrectlylocalTimerServicecorrectly and use millisecond resolutionStill needs: