Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Lerna to v7 #8062

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

update Lerna to v7 #8062

wants to merge 3 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 18, 2023

closes: #4660

Description

Instead of removing Lerna, double down. Upgrade to v7.

https://github.com/lerna/lerna/blob/main/CHANGELOG.md

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@michaelfig
Copy link
Member

Can you please try disabling Nx support?

I found once before that without setting "useNx": false in lerna.json, some of the task running worked strangely. That may be responsible for the CI lint-rest errors, if you can't find any other cause.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any clues as to why the xsnap lint:types is failing? That concerns me, but unless it's NX related, I've got nuttin'.

@@ -1,4 +1,5 @@
{
"useNX": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a lowercase "x":

Suggested change
"useNX": false,
"useNx": false,

@turadg turadg mentioned this pull request Jul 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Lerna
2 participants