feat(graph): also generate the transitive reduction #9359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
be3b9b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f067d2df.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-graph-transitive-reduc.agoric-sdk.pages.dev |
turadg
approved these changes
May 10, 2024
erights
added a commit
to endojs/endo
that referenced
this pull request
May 10, 2024
Closes: #XXXX Refs: Agoric/agoric-sdk#9359 ## Description Use the "tred" executable that seems to already be bundled with graphviz to ``` # Also generates visualizations of the transitive reduction (tred) of # that graph, which is the minimal graph with the same *transitive* # dependencies. Much more legible by itelf. Seeing the two side by side # often helps to understand the full picture. ``` At the time of writing, the current graph of endo dependencies is  and the transitive reduction of those is  Notice how the columns *mostly* align. Unfortunately, the columns don't fully align, and the vertical order of elements within each column is not the same. For viewing them side by side for better understanding, it would be better if both of these annoyances were fixed. But I have no idea how to do that, so this PR does not try. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations potentially helps someone who wants to understand how our system is internally layered, which is the point. Otherwise, none ### Testing Considerations none ### Compatibility Considerations none ### Upgrade Considerations none
|
@Mergifyio requeue |
☑️ This pull request is already queued |
erights
added a commit
to endojs/endo
that referenced
this pull request
Jun 2, 2024
Closes: #XXXX Refs: Agoric/agoric-sdk#9359 ## Description Use the "tred" executable that seems to already be bundled with graphviz to ``` # Also generates visualizations of the transitive reduction (tred) of # that graph, which is the minimal graph with the same *transitive* # dependencies. Much more legible by itelf. Seeing the two side by side # often helps to understand the full picture. ``` At the time of writing, the current graph of endo dependencies is  and the transitive reduction of those is  Notice how the columns *mostly* align. Unfortunately, the columns don't fully align, and the vertical order of elements within each column is not the same. For viewing them side by side for better understanding, it would be better if both of these annoyances were fixed. But I have no idea how to do that, so this PR does not try. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations potentially helps someone who wants to understand how our system is internally layered, which is the point. Otherwise, none ### Testing Considerations none ### Compatibility Considerations none ### Upgrade Considerations none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: endojs/endo#2282
Description
Use the "tred" executable that seems to already be bundled with graphviz to
At the time of writing, the current graph of agoric-sdk dependencies is
and the transitive reduction of those is
Notice how the columns mostly align. Unfortunately, the columns don't fully align, and the vertical order of elements within each column is not the same. For viewing them side by side for better understanding, it would be better if both of these annoyances were fixed. But I have no idea how to do that, so this PR does not try.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
potentially helps someone who wants to understand how our system is internally layered, which is the point. Otherwise, none
Testing Considerations
none
Compatibility Considerations
none
Upgrade Considerations
none