Patch @cosmjs/math for SES compatibility #9583
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
5852855
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5e93326.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-cosmjs-math-patch.agoric-sdk.pages.dev |
| // A test to verify that importing @cosmsjs/math into an ESM via bundleSource | ||
| // can see the exported Decimal constructor, which was at time of writing obscured | ||
| // by https://github.com/endojs/endo/pull/2330, temporarily mitigated by a patch. | ||
| // Placed here only because Agoric CLI depends on both bundleSource and CosmJS math. |
There was a problem hiding this comment.
seems like it should go in cosmic-proto.
There was a problem hiding this comment.
Looks like it was copied rather than moved.
I trust you'll get rid of the copy in agoric-cli before merging.
There was a problem hiding this comment.
Thank you for spotting. This wasn’t obvious locally.
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
d697b4f
to
e985d4f
Compare
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
e985d4f
to
0fdf898
Compare
| // A test to verify that importing @cosmsjs/math into an ESM via bundleSource | ||
| // can see the exported Decimal constructor, which was at time of writing obscured | ||
| // by https://github.com/endojs/endo/pull/2330, temporarily mitigated by a patch. | ||
| // Placed here only because Agoric CLI depends on both bundleSource and CosmJS math. |
There was a problem hiding this comment.
Looks like it was copied rather than moved.
I trust you'll get rid of the copy in agoric-cli before merging.
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
0fdf898
to
6acdcef
Compare
kriskowal
force-pushed
the
kriskowal-cosmjs-math-patch-9408
branch
from
6acdcef
to
5852855
Compare
kriskowal
added
force:integration
|
How does this address the original issue. A patch in agoric-sdk won't affect dapps if the dapp uses packages installed from NPM |
The fix for the underlying issue is endojs/endo#2330 |
closes: #9408
Description
Pending endojs/endo#2330, we patch
@cosmjs/mathsuch that imports from ESM reflect the exported types.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
Included test.
Upgrade Considerations
None.