ci: restore yarn test, excluding e2e; restore node LTS
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
approved these changes
Apr 18, 2024
.github/workflows/pr.yml
Outdated
| @@ -35,6 +35,8 @@ jobs: | |||
| run: yarn start:docker | |||
| - name: yarn build | |||
| run: yarn build | |||
| - name: yarn test | |||
| run: yarn test --exclude "**/e2e/**" | |||
| - name: yarn start:contract | |||
There was a problem hiding this comment.
Maybe better to stick this in the unit job? L23-L24
There was a problem hiding this comment.
oops! yes, that's where I meant to put it...
p.s. I presume you don't mind a force push
There was a problem hiding this comment.
This doesn't look right either:
dapp-offer-up/.github/workflows/pr.yml
Lines 12 to 16 in 70540a2
18.x, or ['18.x', '20.x'] since it's a quick job?
There was a problem hiding this comment.
I'll try it, but see also
dckc
force-pushed
the
dc-yarn-test
branch
2 times, most recently
from
56c7a48
to
aebfd29
Compare
|
(disabling auto-merge until Agoric/agoric-sdk#9250 lands) |
dckc
changed the title
yarn test, excluding e2eyarn test, excluding e2e; restore node LTS
|
odd... ci checks aren't running. I don't see why not. |
I think we might need to do something like: runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['18.x', '20.x']
steps:
- name: Checkout Repo
uses: actions/checkout@v3
- name: Use Node.js LTS versions
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77