Network Dropdown #94
Network Dropdown #94
Conversation
samsiegart
force-pushed
the
chain-selector
branch
2 times, most recently
from
796ccbb
to
ca4d4ab
Compare
samsiegart
force-pushed
the
chain-selector
branch
from
ca4d4ab
to
f19533a
Compare
| // testChain is optional, defaulting to Agoric mainnet otherwise. | ||
| testChain: { | ||
| chainId: 'agoriclocal', | ||
| chainName: 'agoric-local', | ||
| }, |
There was a problem hiding this comment.
nit: is this nesting/testChain key necessary? Maybe just make chainId and chainName optional, noting they will be pulled from chain-registry if not provided?
There was a problem hiding this comment.
I guess the benefit of nesting is:
- You can couple the properties so that you either need both or neither
- It makes it clearer that they're used for test chains rather than mainnet
I suppose there would be a way with ts to do the coupling but I'm not sure if it would be as neat. I lean towards keeping the nesting but just a preference.
|
Did you happen to know why I don't see mainnet in the drop down if Screen.Recording.2024-03-08.at.12.45.06.PM.mov |
|
@LuqiPan Maybe because it's autocompleting and you have to clear the input for "Agoric" to show up (or erase all the characters after "Agoric...". I guess this is an unwelcome quirk of the interchain-ui component... |
fixes: Agoric/agoric-sdk#8933
Tested locally with Agoric/dapp-offer-up@b73b8c0
Screenshot