feat: allow exiting offers #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1a1e82c
|
| Status: | ⚡️ Build in progress... |
samsiegart
force-pushed
the
exit-offer
branch
from
5446615
to
f64dd1b
Compare
turadg
reviewed
Feb 24, 2023
wallet/src/service/Offers.ts
Outdated
| @@ -206,45 +207,95 @@ export const getOfferService = ( | |||
| return signSpendAction(offer.spendAction); | |||
| }; | |||
|
|
|||
| const cancelOffer = _id => { | |||
| console.log('TODO: cancel offer'); | |||
| const cancelOffer = async (id: number) => { | |||
There was a problem hiding this comment.
let's be consistent in terminology:
Suggested change
| const cancelOffer = async (id: number) => { | |
| const tryExitOffer = async (id: number) => { |
"cancel" suggests that it'll always work
turadg
approved these changes
Mar 28, 2023
wallet/src/components/Offer.tsx
Outdated
| <div className="OfferOrigin" style={{ wordBreak: 'break-word' }}> | ||
| <PetnameSpan name={sourceDescription} /> | ||
| <i> via </i> | ||
| <span className="Blue">{dappOrigin || origin}</span> | ||
| {(dappOrigin || origin) && ( |
There was a problem hiding this comment.
consider const actualOrigin = dappOrigin || origin so the condition doesn't need to be repeated on line 142
wallet/src/service/Offers.ts
Outdated
| pendingOffersNotifier, | ||
| )) { | ||
| console.log('pending offers', pendingOffers); | ||
| pendingOffers?.forEach(([_, o]) => { |
There was a problem hiding this comment.
prefer control structures when available. for loop allows continue e.g.,
Suggested change
| pendingOffers?.forEach(([_, o]) => { | |
| if (!pendingOffers) continue; | |
| for (const [_, o] of pendingOffers) { |
| @@ -201,8 +190,8 @@ test('renders the controls', () => { | |||
| expect(controls.find(Chip).at(1).text()).toContain('Decline'); | |||
| }); | |||
|
|
|||
| test.skip('renders the exit button while pending', () => { | |||
| const pendingOffer = { ...offer }; | |||
| test('renders the exit button while seated', () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #61
Tested making liquidation bids from CLI and exiting them from UI