Set a minimum value for evaluation of Zinc (I_C_ZN) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardhros
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
this suggests that the calc_zinc_availability results in too low values? If that is the case, then its better to solve that in the calc_zinc_availability function. Since that requires more recent observations (linking soil properties to Zn crop uptake) and these are missing, i think this is a practical solution that works for the moment. Needs to be updated later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After consultation with Wim, we set a minimum value of I_C_ZN to be 0.4. This is to prevent that parcels with high pH values, for which Zn concentration is underestimated with the current empirical relationship, receive too low scores.
The expected values in the test functions are also updated.