Workability depth #193
Workability depth #193
Conversation
…ding spring_depth to ZCrit.
R/workability.R
Outdated
| #' @param B_SOILTYPE_AGR (character) The agricultural type of soil | ||
| #' @param B_GWL_GLG (numeric) The lowest groundwater level averaged over the most dry periods in 8 years in cm below ground level | ||
| #' @param B_GWL_GHG (numeric) The highest groundwater level averaged over the most wet periods in 8 years in cm below ground level | ||
| #' @param B_GWL_ZCRIT (numeric) The distance between ground level and groundwater level at which the groundwater can supply the soil surface with 2mm water per day (in cm) |
There was a problem hiding this comment.
B_GWL_ZCRIT should be defined as
"Distance between groundwater table and root zone (30 cm -mv) for delivering 2 mm/day"
As is the description of the input data we use.
This has consequences for the changes in line 117. For example, if the spring_workindepth == 30, the Zcrit (to the root zone 0-30cm) already accounts for this working depth and no addition or substraction is needed.
There was a problem hiding this comment.
I pushed another script now that resolves this by firstly chaing the definition in line 15 and then changing the calculation we discussed to Zcrit + springdepth - 30. This way if the working depth is less than the rootzone the depth at which the capilary rise is lower than the evaporation is slightly decreased, if the working depth is larger than the rootzone this depth increases. Good thing is that with this definition the change in depth is smaller making the assumption the soil profile remains the same more reasonable.
I'm not sure if committing went well, please let me know. I can't see how I can ask you to review.
|
Feel free to add yourself as package contributor (ctb) in the DESCRIPTION file. |
…ustions to calculation of depth at which capilary rise to springdepth is lower than the evaporation.
That's weird, only a few lines should have changes. Looking at diffs of individual commits using GitKraken 🐙 it seems 46a01a2 added a trailing space to each line but I do not see all these trailing spaces myself when opening the script in Rstudio with the any of the commits. |
Fixing capilary rise distance for determining workability by adding spring_depth to ZCrit.