Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obi 28 #194

Merged
merged 6 commits into from Feb 12, 2024
Merged

Obi 28 #194

merged 6 commits into from Feb 12, 2024

Conversation

KeesDoolNMI
Copy link
Contributor

Fixes error in validation of B_LU_BRP by updating crops.obic [OBI-28]

NEWS.md Outdated
@@ -1,3 +1,7 @@
# OBIC 3.0.2 2024-02-09
## Fixed
* Fixes error in validation of B_LU_BRP by updating `crops.obic` [OBI-28]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changelog more descriptive. For example that you added new brp codes for 2023 and fixed classification grasland met/zonder herinzaai

Copy link
Member

@SvenVw SvenVw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix unit tests

Copy link
Member

@SvenVw SvenVw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KeesDoolNMI KeesDoolNMI merged commit d213101 into master Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants